Index single tx signup #5408
Merged
Index single tx signup #5408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsolo
requested review from
michellebrier
and removed request for
michellebrier
isaacsolo
force-pushed
the
is-single-tx-signup-indexing
branch
from
aca2614 to
e7e0155
Compare
theoilie
approved these changes
Jun 14, 2023
Contributor
theoilie
left a comment
theoilie
left a comment
There was a problem hiding this comment.
glad to see it working on staging 🔥 I'm curious about the case where libs has this change and Discovery doesn't, or vice-versa. it looks like it should just fallback to the 2-step flow and work, but signup is all complicated with these different v1 and v2 paths so worth calling out
| "_entityType": "User", | ||
| "_userId": USER_ID_OFFSET + 3, | ||
| "_action": "Create", | ||
| "_metadata": f'{{"data": {create_user3_json}}}', |
Contributor
There was a problem hiding this comment.
yes need cid for both v1 and v2
Author
There was a problem hiding this comment.
oh yea for that CID table right?
| # fallback to multi tx signup | ||
| pass | ||
|
|
||
| if params.metadata_cid == "v2": |
Contributor
There was a problem hiding this comment.
should be params.metadata now bc of this change f17be75
| if params.metadata_cid == "v2": | ||
| user_record.is_storage_v2 = True | ||
| else: | ||
| elif not user_metadata: # update replica set case |
Contributor
There was a problem hiding this comment.
couple questions:
- whats the old multi tx flow? a CREATE USER event followed by an UPDATE USER event?
- if so, with the single tx flow i assume we want the cid metadata that would normally be in the UPDATE USER event to be persisted in
cid_dataso the client can query it later?- in which case we either need to add special cases for different metadata formats in CREATE USER events to
expect_cid_metadata_jsonandparse_metadatain entity managerutils.py - or
- handle that here and persist to
cid_dataappropriately - feels convoluted trying to handle all possible CREATE USER cases upstream in
entity_manager.pyas we migrate from multi->single tx and also from storage v1->v2 so would prefer the latter, with the custom logic here
- in which case we either need to add special cases for different metadata formats in CREATE USER events to
- what are all the possible metadata values that we want to handle here? (considering old multi tx path, new single tx path, and v2)
Author
There was a problem hiding this comment.
- Yea, it's a create user, update for the handle, update for profile picture.
- Yeah sg, updating it to treat this case as a user update and parse.
- This will just be for storage v2 so I think the only cases we will have are v2 single tx and v2 multi tx. We can def clean it up once v2 and libs changes go out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, signup takes multiple user txs. This change will allow signups from a single create user tx with metadata.
Libs change in progress: 2c1a0c8
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Added test and tested e2e with libs change on stage