Conversation
theoilie
approved these changes
Jun 21, 2023
| cid_type[metadata_cid] = metadata_type | ||
| cid_metadata[metadata_cid] = params.metadata | ||
| user_record.metadata_multihash = metadata_cid | ||
| user_record = update_legacy_user_images(user_record) |
Contributor
There was a problem hiding this comment.
nit: this flow will only happen for storage v2 users right? maybe it's better to remove this line and stop using update_legacy_user_images going forward, since all the v2 user stuff only sets the correct _sizes fields and not the legacy ones
isaacsolo
pushed a commit
that referenced
this pull request
Jun 23, 2023
This reverts commit 1b19b60.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently sign up can take up to 3 transactions: create user record, update handle, update images. This change makes it a single relay.
Also fixing the indexing side so the metadata is saved to the user record.
How Has This Been Tested?
Linked SDK and tested against stage. Confirmed single tx signup works. Confirmed multi tx signup works.
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.