[C-4860] Add waitlist hint for premium album #9243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
amendelsohn
approved these changes
Jul 23, 2024
| </Tooltip> | ||
| </div> | ||
| {hintContent ? <Hint icon={hintIcon}>{hintContent}</Hint> : null} | ||
| {hint ? <Box pt='s'>{hint}</Box> : null} |
Contributor
There was a problem hiding this comment.
do we want a <Text> around this when hint is a string?
Contributor
Author
There was a problem hiding this comment.
i updated this so hint is a reactnode, so should be chillin
Contributor
There was a problem hiding this comment.
sry my point is that the arg takes string or ReactNode, so in the case it's just a string, we might want to apply harmony text styling to it
If we're never passing string, that's fine but could remove it from the prop type
audius-infra
pushed a commit
that referenced
this pull request
Jul 27, 2024
[bea9c85] Fix previously scheduled edit flow (#9278) Dylan Jeffers [9468507] Improve mobile inner-form revert (#9277) Dylan Jeffers [15ce2a7] [C-3251] Fix initial state for hidden price-audience field (#9276) Dylan Jeffers [51a67b4] Fix runtime issue with advanced field (#9275) Dylan Jeffers [09acfe3] [PAY-3265, PAY-3241] Disallow scheduled playlists in upload/edit; Fix mood placeholder (#9272) Andrew Mendelsohn [65c886a] [C-4690] Wire up advanced search deep links (#9271) Sebastian Klingler [deebd52] [C-4874] Update time to 11:59 when scheduling for same day (#9266) Andrew Mendelsohn [cc407c6] Fix missing refactor bug (#9270) Saliou Diallo [42e8d11] [PAY-3232] Fix hidden visibility bug when setting price and audience fields (#9268) Saliou Diallo [523c341] Revert "Update models used in DN reposts endpoints" (#9269) Randy Schott [89d1e76] [C-4840] Update search screen to auto focus the input (#9263) Kyle Shanks [9e72dba] [C-4867] Fix collection release date timezone (#9267) Dylan Jeffers [f5abafe] [C-4866] Fix edit collection form submit (#9262) Dylan Jeffers [a834436] [PAY-3187] Fix messed up back button form state for payment settings (#9260) Raymond Jacobson [c3c5b45] [PAY-3196][PAY-3230] Fix miscellaneous editable access issues on mobile (#9258) Saliou Diallo [823bc63] [C-4793, C-4791] Don't favorite hidden album tracks on purchase (#9254) Andrew Mendelsohn [6055711] [C-4863] Fix cascading publish on edit collection (#9249) Andrew Mendelsohn [7500e91] [C-4634] Add popularity sort to users and collections (#9250) Dylan Jeffers [cd24c79] [C-4843] [C-4846] More advanced search UI fixes (#9252) Sebastian Klingler [d05de85] [C-4865] Make metadata links visible (#9248) Sebastian Klingler [8ebbb9d] [C-4847] Reset search filters scroll position (#9242) Sebastian Klingler [d43760d] PAY-3186 Fixes issue preventing edit screen from opening twice (#9247) Marcus Pasell [7ffc65c] [C-4834] Animate clear search button for search v2 (#9246) Sebastian Klingler [24ed1c6] [C-4860] Add waitlist hint for premium album (#9243) Dylan Jeffers [b336657] Fix type error from SDK update (#9245) Randy Schott [4fb3d7d] Fix same day scheduled release on web (#9240) Dylan Jeffers [305a9ef] [PAY-3190] Improve profile page pull to refresh (#9241) Raymond Jacobson [73a7131] [C-4841] Fix search v2 navigation on mobile (#9233) Sebastian Klingler [df91fca] [C-4853] Mobile Edit Collection (#9237) Dylan Jeffers [6473ab1] Update models used in DN reposts endpoints (#9228) Randy Schott [2c09b40] [C-4792] Disallow Add To Playlist for hidden tracks (#9236) Andrew Mendelsohn [11f5325] [PAY-3176][PAY-3188][PAY-3193] Include premium tracks in DN playlists for owner (#9234) Saliou Diallo [f495382] Remove use_sdk_purchase_track and use_sdk_purchase_album feature flags (#9192) Marcus Pasell [e45bdae] Remove use_sdk_tips feature flag (and fix indexing check) (#9193) Marcus Pasell [8174034] [C-4832] Fix missing play counts on track tiles (#9230) Kyle Shanks [20e739c] [QA-1442] Add offline indicator to collection card (#9227) Dylan Jeffers [fc3648e] [QA-1463] Change order of mobile action buttons (#9229) Reed [b7ea2fc] [C-4837] Fix links for the searching by electronic subgenre from track page (#9225) Kyle Shanks [3bd33d4] [QA-1452] Fix edit playlist issues (#9226) Dylan Jeffers [cedf459] [C-4848] Remove search v2 responsiveness and fix padding on mobile web (#9224) Sebastian Klingler [e60706c] [C-4842] Fix tag press on mobile for search v2 (#9223) Kyle Shanks [9e455f2] [C-4829] Fix mobile web drawer overflow (#9220) Dylan Jeffers [e0af62a] [QA-1458] Fix artwork image loading (#9219) Dylan Jeffers [4355378] Update dapp-store build artifacts audius-infra [1aa1dd2] [QA-1455] Fix disappearing playlists in sidebar (#9216) Dylan Jeffers [9a7ddbf] [C-4643] Feature flag scheduled premium album release (#9215) Dylan Jeffers [dff2b2d] Bump mobile versions to 107 (#9218) Dylan Jeffers [42611cb] [PAY-3177][PAY-3185] Fix mobile track publish button (#9213) Saliou Diallo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds waitlist hint for premium albums. Also improves hint to use harmony