Skip to content

Makefile improvements to core #9300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phelpsdb merged 1 commit into from
Jul 30, 2024
Merged

Makefile improvements to core #9300

phelpsdb merged 1 commit into from
Jul 30, 2024

Conversation

@phelpsdb
Copy link
Contributor

@phelpsdb phelpsdb commented Jul 30, 2024

Description

Just some minor quality of life improvements and optimizations for the core Makefile.

How Has This Been Tested?

Ran all the commands successfully.

@changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: ff1c1e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@phelpsdb phelpsdb marked this pull request as ready for review July 30, 2024 05:44
@phelpsdb phelpsdb requested a review from alecsavvy July 30, 2024 05:44
phelpsdb
phelpsdb commented Jul 30, 2024
View reviewed changes
core/Makefile
Comment on lines +30 to +42
.PHONY: dev-discovery-1 dev-content-1 dev-content-2 dev-content-3
dev-discovery-1:
@go run main.go -env-file=./infra/dev_config/discovery-one.env

dev-content-1:
@go run main.go -env-file=./infra/dev_config/content-one.env

dev-content-2:
@go run main.go -env-file=./infra/dev_config/content-two.env

dev-content-3:
@go run main.go -env-file=./infra/dev_config/content-three.env

Copy link
Contributor Author

@phelpsdb phelpsdb Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm keeping these under the assumption that they're useful for testing, otherwise I'd just as soon delete them since we have the docker compose file.

Copy link
Contributor

@alecsavvy alecsavvy Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are as they're quicker than rebuilding the container, maybe it's better to use something like air for hotreloading here

alecsavvy
alecsavvy reviewed Jul 30, 2024
View reviewed changes
core/Makefile

dev-content-2::
@go run main.go -env-file=./infra/dev_config/content-two.env
SQL_SRCS := $(shell find db/sql/ -type f -name '*.sql') db/sqlc.yaml
Copy link
Contributor

@alecsavvy alecsavvy Jul 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for if line 24 is unchanged?

Copy link
Contributor Author

@phelpsdb phelpsdb Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for making the gen target only run if the sql files have been modified (line 18)

@phelpsdb phelpsdb merged commit 96e8bff into main Jul 30, 2024
@phelpsdb phelpsdb deleted the phelpsdb-core-makefile branch July 30, 2024 20:49
schottra added a commit that referenced this pull request Jul 30, 2024
@schottra
Merge remote-tracking branch 'origin/main' into pay-3194-reposts-curr…
52c2765 
…ent-user

* origin/main: (74 commits)
  Update users endpoints: round 1 (#9166)
  PAY-3280 Fix gated access display (#9311)
  [PAY-3276] No scheduled playlists (#9312)
  [PAY-3262] Fix edit new playlist (#9309)
  Makefile improvements to core (#9300)
  Update dn models (#9291)
  [PAY-3260] Use 'Today' for matching release dates (#9292)
  [PAY-3258] BoxedTextField can error before form submission (#9305)
  [PAY-3248][PAY-3256][PAY-3234] Fix misc android issues (#9307)
  Premium extras updates (#9306)
  Silence request logs for python es client (#9301)
  [PAY-3263] add playlists & albums release date if null (#9304)
  Small FilterButton hover style tweak (#9303)
  [QA-1448] Fix user badge spacing (#9302)
  [C-4868] BPM validation (#9295)
  [C-4854] Add Premium Extras label (#9294)
  [PAY-3261] Update remix settings copy (#9299)
  Audius Protocol v0.6.158
  Longer deadline for fixing files (#9297)
  [PAY-3236][PAY-3242][PAY-3259] Fix play button in tracks table (#9288)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alecsavvy alecsavvy alecsavvy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phelpsdb @alecsavvy