-
Notifications
You must be signed in to change notification settings - Fork 126
PROTO-1888: core plays #9348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROTO-1888: core plays #9348
Conversation
|
|
is this expected after |
|
Hmm no, make test should be all passing. Do you have |
|
ok, yeah that worked. unreal!! |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11648676 | Triggered | Generic High Entropy Secret | a4022b6 | core/infra/dev_config/discovery-one.docker.env | View secret |
| 11648678 | Triggered | Generic High Entropy Secret | a4022b6 | core/infra/dev_config/content-three.docker.env | View secret |
| 11648679 | Triggered | Generic High Entropy Secret | a4022b6 | core/infra/dev_config/content-two.docker.env | View secret |
| 11648680 | Triggered | Generic High Entropy Secret | a4022b6 | core/infra/dev_config/content-one.docker.env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
* main: (82 commits) Improve useClickOutside (#9377) [PAY-2267] Update stage payment router and program addresses (#9387) [QA-1446] Fix popup alignment (#9389) Audius Protocol v0.6.164 Add priority fees to purchases (#9392) [PAY-3314] Track select dropdown for purchase/remix targeting (#9386) Comments Read/Create E2E - Changes to DB/Discovery/SDK/Desktop UI (#9319) [C-4676] Fix es search returning deactivated content (#9382) [PAY-3331] Purchase/sale endpoint filtering by content id (#9376) cleanup audio analysis code (#9379) [PAY-3330] Fix spacing on RepostsFavoritesStats (#9375) Fix short trending bug (#9378) [QA-1114] Include menu items even if buttons are present (#9381) [QA-875] Use size for es query to fix feed pagination bug (#9380) Audius Protocol v0.6.163 As/proto 1888 core plays (#9348) Remove audius-cmd purchase-content (#9374) [QA-1486] Fix sign up select artists screen (#9371) [PAY-3313] Targeted DMs CTA and modal (#9364) [C-4921] Fix search v2 navigating back from profile (#9370) ...
Description
Because of the way go modules work, a second PR will follow this for the mediorum changes as I couldn't get go workspaces to work reliably. We may want to re-think how to organize all of the go projects so they can be built together.
How Has This Been Tested?
make testwith local stack