Skip to content

Conversation

@alecsavvy
Copy link
Contributor

@alecsavvy alecsavvy commented Aug 1, 2024

Description

  • adds protocol.proto to core
  • adds plays/listens to the message schema
  • adds a grpc server that proxies requests to the inner comet instance
  • adds a ping grpc endpoint
  • adds a grpc kv store endpoint
  • adds multiple integration tests that pass with local stack
  • adds a go script that generates functions for the "options" pattern which makes construction of structs clearer

Because of the way go modules work, a second PR will follow this for the mediorum changes as I couldn't get go workspaces to work reliably. We may want to re-think how to organize all of the go projects so they can be built together.

How Has This Been Tested?

make test with local stack

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2024

⚠️ No Changeset found

Latest commit: 2ae9b2d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alecsavvy alecsavvy requested review from endline and phelpsdb August 1, 2024 20:24
@alecsavvy alecsavvy self-assigned this Aug 1, 2024
@alecsavvy alecsavvy marked this pull request as ready for review August 1, 2024 20:24
@endline
Copy link
Contributor

endline commented Aug 2, 2024

is this expected after make up && make test

Summarizing 4 Failures:
  [FAIL] Plays [It] submits and reads back a play through grpc
  /private/var/orion/audius/audius-protocol/core/test/integration/plays_test.go:61
  [FAIL] KvStore [It] should set kv values on one node and read on the others
  /private/var/orion/audius/audius-protocol/core/test/integration/kv_store_test.go:27
  [FAIL] Sdk [It] connects to json rpc endpoint
  /private/var/orion/audius/audius-protocol/core/test/integration/sdk_test.go:22
  [FAIL] Network [It] should be on the same network and peer
  /private/var/orion/audius/audius-protocol/core/test/integration/network_test.go:19

@alecsavvy
Copy link
Contributor Author

alecsavvy commented Aug 2, 2024

Hmm no, make test should be all passing. Do you have audius-compose up running alongside it? that's a dependency @endline

@endline
Copy link
Contributor

endline commented Aug 2, 2024

ok, yeah that worked. unreal!!

@gitguardian
Copy link

gitguardian bot commented Aug 6, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11648676 Triggered Generic High Entropy Secret a4022b6 core/infra/dev_config/discovery-one.docker.env View secret
11648678 Triggered Generic High Entropy Secret a4022b6 core/infra/dev_config/content-three.docker.env View secret
11648679 Triggered Generic High Entropy Secret a4022b6 core/infra/dev_config/content-two.docker.env View secret
11648680 Triggered Generic High Entropy Secret a4022b6 core/infra/dev_config/content-one.docker.env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@alecsavvy alecsavvy enabled auto-merge (squash) August 6, 2024 14:27
@alecsavvy alecsavvy changed the title As/proto 1888 core plays PROTO-1888: core plays Aug 6, 2024
@alecsavvy alecsavvy merged commit 0a4a5cf into main Aug 6, 2024
@alecsavvy alecsavvy deleted the as/proto-1888-core-plays branch August 6, 2024 14:37
schottra added a commit that referenced this pull request Aug 7, 2024
* main: (82 commits)
  Improve useClickOutside (#9377)
  [PAY-2267] Update stage payment router and program addresses (#9387)
  [QA-1446] Fix popup alignment (#9389)
  Audius Protocol v0.6.164
  Add priority fees to purchases (#9392)
  [PAY-3314] Track select dropdown for purchase/remix targeting (#9386)
  Comments Read/Create E2E - Changes to DB/Discovery/SDK/Desktop UI (#9319)
  [C-4676] Fix es search returning deactivated content (#9382)
  [PAY-3331] Purchase/sale endpoint filtering by content id (#9376)
  cleanup audio analysis code (#9379)
  [PAY-3330] Fix spacing on RepostsFavoritesStats (#9375)
  Fix short trending bug (#9378)
  [QA-1114] Include menu items even if buttons are present (#9381)
  [QA-875] Use size for es query to fix feed pagination bug (#9380)
  Audius Protocol v0.6.163
  As/proto 1888 core plays (#9348)
  Remove audius-cmd purchase-content (#9374)
  [QA-1486] Fix sign up select artists screen (#9371)
  [PAY-3313] Targeted DMs CTA and modal (#9364)
  [C-4921] Fix search v2 navigating back from profile (#9370)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants