Skip to content

Small repairer clean up #9405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michellebrier merged 2 commits into from
Aug 8, 2024
Merged

Small repairer clean up #9405

michellebrier merged 2 commits into from
Aug 8, 2024

Conversation

@michellebrier
Copy link
Contributor

@michellebrier michellebrier commented Aug 8, 2024 •
edited
Loading

Description

  • track_id is randomized. better to order by created_at
  • remove 404 clause; is not be relevant after backfill
  • tx is running and idle for 10mins bc of the network reqs. fix by only opening a db session for the query, then each write

How Has This Been Tested?

will test on stage

@michellebrier michellebrier requested a review from sliptype August 8, 2024 21:03
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c8437d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Aug 8, 2024
sliptype
sliptype approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@sliptype sliptype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@michellebrier michellebrier enabled auto-merge (squash) August 8, 2024 21:18
@michellebrier michellebrier disabled auto-merge August 8, 2024 21:32
@michellebrier michellebrier merged commit d38870a into main Aug 8, 2024
@michellebrier michellebrier deleted the mbrier/improve-repair-query branch August 8, 2024 21:32
audius-infra pushed a commit that referenced this pull request Aug 9, 2024
Audius Protocol v0.6.166
59b092f 
[876e321] [QA-1459] Fix 0087_fix_slugs_with_slash.sql migration (#9411) Raymond Jacobson
[c34cd83] Record Track Downloads via Entity Manager (#9103) Marcus Pasell
[d38870a] Small repairer clean up (#9405) Michelle Brier
[8cd3d6c] Payment router exception for when no geo_data found in memo (#9404) Reed
[53bf3e2] [PAY-3321][PAY-3333] Add network cut feature flag and update staking bridge and payment router addresses (#9393) Saliou Diallo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sliptype sliptype sliptype approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michellebrier @sliptype