Skip to content

bump web3 version for ci #9457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alecsavvy merged 1 commit into from
Aug 15, 2024
Merged

bump web3 version for ci #9457

alecsavvy merged 1 commit into from
Aug 15, 2024

Conversation

@alecsavvy
Copy link
Contributor

@alecsavvy alecsavvy commented Aug 15, 2024

Description

transient python deps again, eth_typing had an issue with exporting ContractName, is fixed in a future web3 version so upgraded.
ethereum/eth-typing#63

How Has This Been Tested?

audius-compose test discovery-provider

@alecsavvy alecsavvy requested review from phelpsdb and schottra August 15, 2024 16:25
@alecsavvy alecsavvy self-assigned this Aug 15, 2024
@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2024

⚠️ No Changeset found

Latest commit: 5c65e9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

schottra
schottra approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@schottra schottra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, is there a way we can verify this doesn't actually break anything?

@alecsavvy
Copy link
Contributor Author

alecsavvy commented Aug 15, 2024

@schottra outside of the test suite i'm not too sure

@alecsavvy alecsavvy merged commit 77814a9 into main Aug 15, 2024
@alecsavvy alecsavvy deleted the as/fix-eth-typing branch August 15, 2024 17:11
@phelpsdb
Copy link
Contributor

phelpsdb commented Aug 15, 2024

I don't see any breaking changes in the release notes since the last version we were using.

audius-infra pushed a commit that referenced this pull request Aug 16, 2024
Audius Protocol v0.6.170
569d756 
[11bf6e3] Don't decrypt plaintext chat.last_message (#9470) Reed
[5ba67f8] Fix chat deadlock (#9460) Reed
[fbb4256] [PAY-2917] Migrate user endpoints to SDK, round 3 (#9432) Randy Schott
[77814a9] bump web3 version for ci (#9457) alecsavvy
[2c1679a] [PAY-3307] Upgrade chat blasts to chats in sdk (V2) (#9453) Reed
[279a9b2] More explicit audience columns for chat blast. (#9454) Steve Perkins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@phelpsdb phelpsdb phelpsdb approved these changes

@schottra schottra schottra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alecsavvy alecsavvy

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alecsavvy @phelpsdb @schottra