Skip to content

Conversation

@alecsavvy
Copy link
Contributor

@alecsavvy alecsavvy commented Aug 20, 2024

Description

  • imports core sdk into mediorum
  • initializes core sdk based on env var
  • fires and forgets listen txs into core

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2024

⚠️ No Changeset found

Latest commit: 2c1502c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alecsavvy alecsavvy self-assigned this Aug 21, 2024
@alecsavvy alecsavvy marked this pull request as ready for review August 21, 2024 19:15
Copy link
Contributor

@endline endline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved per log change described above

Copy link
Contributor

@endline endline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice additions

@alecsavvy
Copy link
Contributor Author

marking do-not-merge until hostname configurations are figured out

@gitguardian
Copy link

gitguardian bot commented Aug 29, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9349019 Triggered Generic High Entropy Secret 2c1502c dev-tools/config.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@alecsavvy alecsavvy merged commit 2b82b58 into main Aug 29, 2024
@alecsavvy alecsavvy deleted the as/mediorum-core branch August 29, 2024 20:45
audius-infra pushed a commit that referenced this pull request Aug 30, 2024
[92737e3] [PAY-3372] Add sales aggregate endpoint (#9585) Andrew Mendelsohn
[2b82b58] record listens from mediorum into core (#9501) alecsavvy
[83bb4bb] Set default comment entity_type in indexing (#9580) Dylan Jeffers
[906f90a] [PAY-3377] Migrate remaining apiClient endpoints to SDK (#9559) Randy Schott
[c908aef] Fix mobile comment overflow menu lint (#9577) Dylan Jeffers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants