Skip to content

Conversation

@stereosteve
Copy link
Contributor

Adds audiences: supporter, remixer, customer.

@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2024

⚠️ No Changeset found

Latest commit: 0cb3414

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dharit-tan dharit-tan changed the title Chat blast: support more audiences [PAY-3363] Chat blast: support more audiences Aug 22, 2024

// -------------------------------- tipper audience

// create some follower audiuence
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "tipper audience"

assert.Len(t, pending, 1)
}

// 69 upgrades
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious why 69 upgrades. should work either way but we should also have a test (maybe for another audience) where the recipient upgrades.

Copy link
Contributor

@dharit-tan dharit-tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fire

@stereosteve stereosteve merged commit 7d1ea58 into main Aug 23, 2024
@stereosteve stereosteve deleted the chat-blast-audience-support branch August 23, 2024 16:48
audius-infra pushed a commit that referenced this pull request Aug 26, 2024
[1ba94b8] Reland "[PAY-3357] Migrate Notifications to SDK" (#9539) Marcus Pasell
[c33b4e3] Revert "[PAY-3357] Migrate Notifications to SDK" (#9538) Marcus Pasell
[b8c360e] [PAY-3357] Migrate Notifications to SDK (#9516) Marcus Pasell
[4bbfeff] [PAY-3373] Purchasers endpoint (#9525) Reed
[7d1ea58] [PAY-3363] Chat blast: support more audiences (#9524) Steve Perkins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants