[C-4968] Sort pinned comments to top#9677
Merged
dylanjeffers merged 1 commit intomainfrom Sep 16, 2024
Merged
Conversation
|
Collaborator
|
Preview this change https://demo.audius.co/c-4968-pin-sort |
dylanjeffers
requested review from
a team and
DejayJD
and removed request for
a team
sliptype
approved these changes
Sep 9, 2024
dylanjeffers
changed the title
DejayJD
reviewed
Sep 16, 2024
| Comment.is_delete == False, | ||
| ) | ||
| .order_by(asc(Comment.created_at)) | ||
| .order_by(desc(Comment.is_pinned), sort_method_order_by) |
Contributor
There was a problem hiding this comment.
I'm assuming this is the only change over the other PR?
DejayJD
approved these changes
Sep 16, 2024
Contributor
DejayJD
left a comment
DejayJD
left a comment
There was a problem hiding this comment.
Looks straightforward to me (after the other PR goes in)
dylanjeffers
changed the title
dylanjeffers
force-pushed
the
c-4968-pin-sort
branch
from
4fea40a to
622b534
Compare
audius-infra
pushed a commit
that referenced
this pull request
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensures pinned comments are sorted to the top of the sort list.
Adds test
Note, his includes all the sort changes, which have yet to be reviewed in another pr