Connection: Make sure port is an integer#13523
Merged
Merged
Conversation
tyxla
added
Bug
github-actions
Bot
added
the
[Status] Needs Package Release
brbrr
approved these changes
Sep 24, 2019
Contributor
brbrr
left a comment
brbrr
left a comment
There was a problem hiding this comment.
Looks good. let's wait for e2e tests in CI
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: October 1, 2019. |
Contributor
|
Yay, tests are green! merging |
matticbot
added
[Status] Needs Changelog
and removed
[Status] Needs Review
brbrr
removed
the
[Status] Needs Package Release
Contributor
|
Released in automattic/jetpack-connection@1.0.4 |
jeherve
pushed a commit
that referenced
this pull request
Sep 24, 2019
Member
|
Cherry-picked to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes
HTTP_X_FORWARDED_PORTcan be a string, which after #13489 will cause issues with signature generation. This PR converts those ports to integer, to ensure proper comparison.Changes proposed in this Pull Request:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
Proposed changelog entry for your changes: