SEO: do not display any tags in post titles display in meta tags#13986
Merged
Conversation
Fixes 4478-gh-jpop-issues Some plugins use the the_title filter to add HTML to post titles (to add schema.org metadata for example). We consequently cannot assume anything returned by get_the_title() will be safe to display in a meta tag. Let's use the_title_attribute() instead to avoid having any unwanted HTML.
jeherve
added
Bug
Contributor
|
Caution: This PR has changes that must be merged to WordPress.com |
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: December 3, 2019. |
ChaosExAnima
approved these changes
Nov 20, 2019
ChaosExAnima
added
[Status] Ready to Merge
matticbot
added
[Status] Needs Changelog
and removed
[Status] Ready to Merge
jeherve
added a commit
that referenced
this pull request
Nov 25, 2019
* 8.0 Release: running changelog * Changelog: add #13921 * Changelog: add #13980 * Changelog: add #13905 * Changelog: add #13971 * Changelog: add #13984 * Changelog: add #14009 * Changelog: add #13620 * Remove things that will ship in 7.9.1 * Changelog: add 7.9.1 release (#14044) * Changelog: add base for 7.9.1 release * Update release date and post link * Changelog: add #14066 * Update changelog for 7.9.1 * Changelog: add #13405 * Changelog: add #13841 * Changelog: add #13924 * Changelog: add #13986 * Changelog: add #14010, #14028, #14053, #14055. * Changelog: add #14054 * Changelog: add #14031 * Changelog: add #14039 * Changelog: add #14050 * Changelog: add #14070 * Changelog: add #14082 * Changelog: add #14084 * Changelog: add #14111 * Changelog: add #13961 * Changelog: add #14047 * Changelog: add #14091 * Changelog: add #14108 * Changelog: add #14121
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 4478-gh-jpop-issues
Changes proposed in this Pull Request:
Some plugins use the
the_titlefilter to add HTML to post titles (to add schema.org metadata for example).We consequently cannot assume anything returned by
get_the_title()will be safe to display in a meta tag.Let's use
the_title_attribute()instead to avoid having any unwanted HTML.Testing instructions:
Start from a site running Jetpack Premium and where you've set posts to use a custom meta tag in SEO settings in Calypso:
Install the Easy Digital Downloads plugin
Create a Download
View it, and check the meta tag.
Proposed changelog entry for your changes: