Images: Updated access to consider public secure_restricted#5909
Merged
ssddanbrown merged 2 commits intodevelopmentfrom Nov 21, 2025
Merged
Images: Updated access to consider public secure_restricted#5909ssddanbrown merged 2 commits intodevelopmentfrom
ssddanbrown merged 2 commits intodevelopmentfrom
Conversation
Had prevented public access for images when secure_restricted images was enabled (and for just secure images) when app settings allowed public access. This considers the app public setting, and adds tests to cover extra scenarios to prevent regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had prevented public access for images when secure_restricted images was enabled (and for just secure images) when app settings allowed public access.
This considers the app public setting, and adds tests to cover extra scenarios to prevent regression.
Related to #5906