Remove inc_config (Issue #1081)#1335
Merged
tanyongkiam merged 34 commits intomasterfrom Feb 16, 2026
Merged
Conversation
Change shmem_info entry_pc assumptions from word-space to num-space throughout lab_to_targetProofScript.sml to match the shmem_info_num type change (entry_pc is now num, not word). - IMP_state_rel_make_init: replace two cheats with full proofs handling the num-space find_index and DISJOINT conditions - Add find_index_MAP_w2n helper lemma (using w2n injectivity) - semantics_compile_lemma/semantics_compile: change DROP assumption from word-space to num-space (MAP w2n on ffi_entry_pcs) Co-Authored-By: Claude Opus 4.6 <[email protected]>
Adapt config files, config proofs, cv_translator, backend_asm, backend_enc_dec, backend_itreeProof, and pancake proofs to use the simplified backend$config type (no more inc_config/config_to_inc_config). All changes verified by successful Holmake builds. pan_to_targetProof has one remaining cheat in the good_code subgoal. Co-Authored-By: Claude Opus 4.6 <[email protected]>
…ESTED)
Adapt compilerScript, compilerProof, bootstrap translation/compilation,
scheme proof, and scpog proof for the inc_config removal (issue 1081).
Also fix shmem_rec -> shmem_info_num in to_target{32,64}Prog and
delete stale commented-out code in backendProof.
NOT YET TESTED - these files could not be built because compilerTheory
depends on basis/ which needs rebuilding after upstream merge.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
- Fix Unicode smart quotes in decodeProgScript (type quotations need
U+201C/U+201D, not ASCII double quotes)
- Fix compile_tap_compile theorem to include asm_conf parameter
- Rewrite arm8_asl_compile_correct to use Q.GENL/Q.ISPECL style
- Fix 64 backend$config -> backend$config in 14 example proof files
(config type is no longer polymorphic)
- Fix c.asm_conf -> ac in to_target{32,64}ProgScript
(asm_conf is no longer a field of lab_to_target$config)
Co-Authored-By: Claude Opus 4.6 <[email protected]>
After inc_config removal, asm_conf is a separate argument in backendTheory and backend_passesTheory, making many definitions in backend_asmScript.sml exact duplicates. Delete them and update references: - Remove to_flat/clos/bvl/bvi/data/word_0/livesets_0/livesets defs (now in backendTheory) - Remove to_flat_all through to_data_all defs (now in backend_passesTheory) - Remove correspondence proofs (to_flat_thm through to_livesets_thm) - Simplify compile_cake_thm proof - Update backend_asmLib.sml to qualify backendTheory refs - Update to_data_cvScript.sml theory references Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
xrchz
reviewed
Feb 15, 2026
xrchz
approved these changes
Feb 15, 2026
Member
xrchz
left a comment
xrchz
left a comment
There was a problem hiding this comment.
if it passes the regression tests, seems good to me
Member
|
seems like you might be another victim of anthropics/claude-code#13939 |
Contributor
Author
|
regression passes fully now (ran locally) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes inc_config and thus fixes #1081
However, note that this does not remove all possible code duplication in backend_asm (which could be done separately).