Conversation
Replace the 47-constructor flatLang$op datatype with a Src ast$op wrapper plus 7 FlatLang-specific constructors (GlobalVarAlloc, GlobalVarInit, GlobalVarLookup, TagLenEq, LenEq, El, Id), reducing maintenance burden when adding new source ops. Updates all definition files, semantics, and proof files. One proof (do_app_SOME_flat_state_rel in flat_elimProof) is temporarily cheated pending restructuring of the case analysis for the new Src wrapper. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Restructure the do_app case analysis to handle the new Src ast$op wrapper in flatLang$op. The old approach using REWRITE_RULE [do_app_cases] timed out because the Src disjunct is very large. Instead, use Cases_on op followed by Cases_on aop, with targeted tactics for store_alloc, store_assign/LUPDATE, Boolv tag tautology, and REPLICATE goals. Also fix deprecated Triviality to Theorem[local]. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
myreen
approved these changes
Feb 19, 2026
Contributor
myreen
left a comment
myreen
left a comment
There was a problem hiding this comment.
This looks great! I'm surprised Claude went and also improved/modernised some proofs that are not affected by this change to Op.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created almost entirely autonomously based on the issue description (with https://github.com/charles-cooper/hol4-mcp).