Refactor mem_load_32 and mem_store_32 to use word_of_bytes/get_byte#1339
Merged
tanyongkiam merged 1 commit intomasterfrom Feb 21, 2026
Merged
Refactor mem_load_32 and mem_store_32 to use word_of_bytes/get_byte#1339tanyongkiam merged 1 commit intomasterfrom
tanyongkiam merged 1 commit intomasterfrom
Conversation
Replace manual shift/OR byte reconstruction in mem_load_32 with word_of_bytes, and manual shift extraction in mem_store_32 with get_byte, eliminating duplicate BE/LE code paths in both wordSem and panSem. Old forms preserved as _alt theorems; downstream proofs updated to reference _alt. Co-Authored-By: Claude Opus 4.6 <[email protected]>
myreen
approved these changes
Feb 20, 2026
Contributor
myreen
left a comment
myreen
left a comment
There was a problem hiding this comment.
This is a welcome improvement! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace manual shift/OR byte reconstruction in mem_load_32 with word_of_bytes, and manual shift extraction in mem_store_32 with get_byte, eliminating duplicate BE/LE code paths in both wordSem and panSem. Old forms preserved as _alt theorems; downstream proofs updated to reference _alt.
@wildptr and @myreen pointed out that the defs that shift words around using w2w are very unwieldy.