Adjust desugaring of OCaml to CakeML AST#1345
Merged
tanyongkiam merged 5 commits intomasterfrom Mar 8, 2026
Merged
Conversation
dnezam
added
the
test failing
Summary:
(-) => (~-) instead of Int.(~)
(-.) => (~-.) instead of Double.(~)
OCaml indexing => Array.get instead of Array.sub
true => Cake.Bool.true (instead of True)
false => Cake.Bool.false (instead of False)
The idea is to desugar into the OCaml interface (which is defined early in
Candle), instead of the CakeML interface (which Candle shadows as soon as
possible), enabling a more consistent interface.
Hopefully by desugaring {true,false} to "Cake.Bool.{true,false}" users can use
"True" and "False" as constructor names without making the boolean literals unusable.
dnezam
changed the title
dnezam
added
test failing
dnezam
added
test failing
With the change to how booleans are desugared, very early files need to use the CakeML constructor directly.
dnezam
removed
the
test failing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
(-) => (~-) instead of Int.(~)
(-.) => (~-.) instead of Double.(~)
OCaml indexing => Array.get instead of Array.sub
true => Cake.Bool.true (instead of True)
false => Cake.Bool.false (instead of False)
The idea is to desugar into the OCaml interface (which is defined early in
Candle), instead of the CakeML interface (which Candle shadows as soon as
possible), enabling a more consistent interface.
Hopefully by desugaring {true,false} to "Cake.Bool.{true,false}" users can use
"True" and "False" as constructor names without making the boolean literals unusable.