View Task Output Using Terminal Emulator#2088
Merged
thecoolwinter merged 27 commits intoCodeEditApp:mainfrom Jul 21, 2025
Merged
View Task Output Using Terminal Emulator#2088thecoolwinter merged 27 commits intoCodeEditApp:mainfrom
thecoolwinter merged 27 commits intoCodeEditApp:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Enhances how tasks run in the terminal emulator by capturing live shell output and streamlining tests with an async helper
- Adds
waitForExpectationutility to replaceXCTestExpectationpatterns - Refactors
TerminalEmulatorViewinto distinct.shelland.taskmodes and updates shell integration to honor aninteractiveflag - Converts
CEActiveTaskto publish a terminal view for live output, updates task management, and migrates tests to the newTestingframework
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| CodeEditTests/Utils/waitForExpectation.swift | New async helper for test predicates instead of XCTestExpectation |
| CodeEdit/Features/TerminalEmulator/Views/TerminalEmulatorView.swift | Split view into shell/task modes and integrate caching |
| CodeEdit/Features/TerminalEmulator/Model/ShellIntegration.swift | Added interactive parameter and history‐disable flag for both bash and zsh |
| CodeEdit/Features/Tasks/Models/CEActiveTask.swift | Switched output from String to terminal view and updated process lifecycle |
Comments suppressed due to low confidence (2)
CodeEdit/Features/Tasks/TaskManager.swift:23
- Removing the default
= nilforworkspaceURLis a breaking change for callers that rely on omitting that argument. Consider restoring the default value (workspaceURL: URL? = nil) or updating all call sites.
init(workspaceSettings: CEWorkspaceSettingsData, workspaceURL: URL?) {
CodeEditTests/Features/TerminalEmulator/ShellIntegrationTests.swift:20
- All existing tests pass
interactive: true, but there’s no coverage forinteractive: falseto assert that non-interactive sessions behave correctly. Consider adding tests for the false case.
interactive: true
CodeEdit/Features/TerminalEmulator/Views/TerminalEmulatorView.swift
Outdated
Show resolved
Hide resolved
…er/CodeEdit into terminal-task-output
austincondiff
approved these changes
Jul 18, 2025
0xWDG
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Utilizes the terminal emulator to both run tasks and display output.
Related Issues
Checklist
Screenshots
Screen.Recording.2025-07-15.at.2.28.32.PM.mov