Bugfix: resolve invalid references#145
Merged
jullrich merged 2 commits intoDShield-ISC:masterfrom Mar 26, 2020
lightswitch05:bugfix/resolve-invalid-references
Merged
Bugfix: resolve invalid references#145jullrich merged 2 commits intoDShield-ISC:masterfrom lightswitch05:bugfix/resolve-invalid-references
jullrich merged 2 commits intoDShield-ISC:masterfrom
lightswitch05:bugfix/resolve-invalid-references
Conversation
…r: unsupported operand type(s) for +: 'NoneType' and 'str'
Contributor
Author
|
Any comments on this change? |
jullrich
approved these changes
Mar 26, 2020
jullrich
approved these changes
Mar 26, 2020
Contributor
|
sorry I missed these. So thanks for the "bump". Just approved them / merging them now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Traceback in
/srv/dshield/fwlogparser.pyChecking my syslog, I noticed a traceback in
fwlogparser.py:By providing a default value for
HOME, the type error will no longer occur.Correct log reference when using an alt config
I have not experienced issues with this fix, but I noticed that
sis never defined. I corrected the log message to use the value fromargs['-c']