-
-
Notifications
You must be signed in to change notification settings - Fork 157
feat(git): add image preview support in diff viewer #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(git): add image preview support in diff viewer #234
Conversation
059b162 to
57c9e63
Compare
8e00954 to
7cc2908
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
7cc2908 to
7a5f844
Compare
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
heads up @Dimillian , I pushed a small change after original codex review ran |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
One more run then. FYI I'll do manual testing and small fixes if needed before merge tonight or tomorrow. Thanks for the feature added to the diff viewer! |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Motivation
Description
image_mime_type()helper in Rust to detect image files by extension and provide MIME types (png, jpg, jpeg, gif, webp, svg, bmp, ico)GitFileDiffwithis_binary,is_image,old_image_data,new_image_data, plusold_image_mime/new_image_mimefor correct per-side previewsget_git_diffs()to load old/new image previews per-side, skip non-image sides, and enforce a 10MB cap to keep IPC responsiveImageDiffCardReact component with side-by-side before/after comparisonuseGitDiffshook to pass through image metadata fields to the diff viewerTesting
npm run lintpassednpm run testpassed (180 tests)npm run typecheckpassedcargo testpassed (32 tests + daemon/tests)Screen.Recording.2026-01-25.at.9.14.33.AM.mov