Skip to content

Conversation

@lionellc
Copy link
Contributor

Summary

  • Render attached images in message bubbles as a horizontal grid.
  • Add lightbox preview for image thumbnails with ESC/overlay close.
  • Parse user message image inputs into structured image URLs.

Testing

  • Added Messages component test for image grid + lightbox.
  • Updated thread item parsing test for image URLs.

@Dimillian
Copy link
Owner

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f6851fce3b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@lionellc
Copy link
Contributor Author

lionellc commented Jan 29, 2026

My fix is to stop inserting [image] placeholders into the message text and remove the second-pass normalization that collapses whitespace. This preserves original newlines/indentation and avoids flattening Markdown when images are attached.
The trade‑off is that historical messages containing [image] will continue to display that literal text, but that impact is small; directly stripping [image] is unsafe because users may have typed [image] intentionally.

@Dimillian

@Dimillian
Copy link
Owner

@codex review

@Dimillian
Copy link
Owner

My fix is to stop inserting [image] placeholders into the message text and remove the second-pass normalization that collapses whitespace. This preserves original newlines/indentation and avoids flattening Markdown when images are attached. The trade‑off is that historical messages containing [image] will continue to display that literal text, but that impact is small; directly stripping [image] is unsafe because users may have typed [image] intentionally.

@Dimillian

Yes it's fine

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Dimillian Dimillian merged commit b5ea7b6 into Dimillian:main Jan 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants