Skip to content

Add a runtime setting on frameview to pack or not#83

Merged
hrydgard merged 1 commit into
mainfrom
packing-optional
Jun 9, 2022
Merged

Add a runtime setting on frameview to pack or not#83
hrydgard merged 1 commit into
mainfrom
packing-optional

Conversation

@hrydgard
Copy link
Copy Markdown
Contributor

@hrydgard hrydgard commented Jun 3, 2022

In interactive mode (directly in the client), we don't save a lot of history and thus compression/packing isn't worth the quite noticeable frame time. Still we want the capability compiled in, so this simply adds a runtime option that can be used to turn it off when not needed.

See #82 .

@hrydgard hrydgard requested review from VZout and emilk as code owners June 3, 2022 09:54
@hrydgard
Copy link
Copy Markdown
Contributor Author

hrydgard commented Jun 9, 2022

I'm just gonna go ahead and merge this simple change.

@hrydgard hrydgard merged commit 9ae635c into main Jun 9, 2022
@hrydgard hrydgard deleted the packing-optional branch June 9, 2022 14:17
hrydgard added a commit that referenced this pull request Jun 9, 2022
I believe #83 is fine to do as a minor update, semver-wise.
@hrydgard hrydgard mentioned this pull request Jun 9, 2022
mergify Bot pushed a commit that referenced this pull request Jun 10, 2022
I believe #83 is fine to do as a minor update, semver-wise.
@repi repi mentioned this pull request Nov 7, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants