Skip to content

Conversation

@dgibbs64
Copy link
Member

@dgibbs64 dgibbs64 commented Jun 11, 2023

Description

To allow ansible and other tools to better use serverlist.csv a header has been added

Fixes #[issue]

Type of change

  • Bug fix (a change which fixes an issue).
  • New feature (a change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).

Checklist

PR will not be merged until all steps are complete.

  • This pull request links to an issue.
  • This pull request uses the develop branch as its base.
  • This pull request subject follows the Conventional Commits standard.
  • This code follows the style guidelines of this project.
  • I have performed a self-review of my code.
  • I have checked that this code is commented where required.
  • I have provided a detailed enough description of this PR.
  • I have checked if documentation needs updating.

Documentation

If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.

Thank you for your Pull Request!

dgibbs64 added 3 commits June 11, 2023 14:34
added header to serverlistto help ansible and other tools better work with the csv file
The script now skips the first line of the serverlist file when generating the list for 'list' and 'install' commands. This ensures that the header is not included in the output.
@dgibbs64 dgibbs64 added this to the v23.4.0 milestone Jun 11, 2023
@dgibbs64 dgibbs64 merged commit 2cebdfe into develop Jun 11, 2023
@dgibbs64 dgibbs64 deleted the feature/serverlist-header branch June 11, 2023 15:24
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants