Update Gradle JavaCC parser to latest version (3.0.0)#1843
Merged
manticore-projects merged 1 commit intoJSQLParser:masterfrom Aug 5, 2023
Merged
Update Gradle JavaCC parser to latest version (3.0.0)#1843manticore-projects merged 1 commit intoJSQLParser:masterfrom
manticore-projects merged 1 commit intoJSQLParser:masterfrom
Conversation
Contributor
|
Awesome! Thank you very much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New version of the JavaCC plugin is out: release notes. Because the plugin ID changed, it won't be found by usual dependency update mechanisms, so I'm making PRs manually to update the major projects on GitHub that are using an older version of the plugin.
The new version should make compilation of the parser a bit faster and improve compatibility with future releases of Gradle.
I locally checked that
./gradlew testis successful with this change, but have not done any other testing.Personally I'd suggest to use specific versions of plugins in the Gradle file rather than
latest.release, but I did not change it here.The warnings before and after seem to be the same: