feat: support mysql with rollup#1923
Conversation
src/test/resources/net/sf/jsqlparser/statement/select/oracle-tests/merge04.sql
Show resolved
Hide resolved
src/test/java/net/sf/jsqlparser/statement/select/SelectTest.java
Outdated
Show resolved
Hide resolved
| this.mysqlWithRollup = mysqlWithRollup; | ||
| } | ||
|
|
||
| public GroupByElement withMysqlWithRollup(boolean mysqlWithRollup) { |
There was a problem hiding this comment.
I know, that previously those "withMethods" have been implemented, but nobody ever gave me a reason why the "setMethod" should not return the object directly.
Feel free to avoid that redundant "withMethod" and return the object when calling the "set" method.
There was a problem hiding this comment.
To my knowledge, in functional programming, it is generally referred to as with. The true meaning is to create a new object and return it without modifying the object itself, but here, with modifies the object, so set and with are indeed duplicates at this point.
|
I have fixed the Test related issues not linked to this PR directly. Please re-sync, sorry for the extra step. |
Thank you, I have revised it. |
|
Thank you for working on this! |
2 participants
try to closed #1907