fix: data race issue due to mutating http.DefaultTransport#1915
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1915 +/- ##
==========================================
- Coverage 33.70% 33.54% -0.17%
==========================================
Files 76 76
Lines 6682 6711 +29
==========================================
- Hits 2252 2251 -1
- Misses 4251 4280 +29
- Partials 179 180 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prashansa-K
force-pushed
the
fix/data-race-issue-konnect
branch
from
cc06b2e to
9eaa53c
Compare
Merged
5 tasks
Prashansa-K
force-pushed
the
fix/data-race-issue-konnect
branch
from
4721178 to
43d2d0e
Compare
Prashansa-K
force-pushed
the
fix/data-race-issue-konnect
branch
from
43d2d0e to
c8cd262
Compare
…line errors in CI
Prashansa-K
commented
Mar 6, 2026
| } | ||
| // get Konnect client | ||
| httpClient, err := utils.HTTPClientWithTLSConfig(rootConfig.TLSConfig) | ||
| httpClient, err := utils.HTTPClientWithOpts(utils.HTTPClientOptions{ |
Contributor
Author
There was a problem hiding this comment.
Switched to the new method so that timeout field can be same as the one passed by the users in the config. If nothing is passed, default timeout = 10s is set.
Prashansa-K
commented
Mar 6, 2026
| Args: validateNoArgs, | ||
| RunE: func(cmd *cobra.Command, _ []string) error { | ||
| httpClient := utils.HTTPClient() | ||
| httpClient, err := utils.HTTPClientWithOpts(utils.HTTPClientOptions{ |
Contributor
Author
There was a problem hiding this comment.
Bunch of these functions are not used anymore or are in alpha state and deprecated. Not dealing with removal as a part of this PR.
Prashansa-K
commented
Mar 6, 2026
| DECK_KONNECT_PASSWORD : ${{ secrets.DECK_KONNECT_PASSWORD }} | ||
| DECK_KONNECT_ADDR : ${{ secrets.DECK_KONNECT_ADDR }} | ||
| DECK_KONNECT_TOKEN : ${{ secrets.DECK_KONNECT_TOKEN }} | ||
| DECK_TIMEOUT: ${{ vars.DECK_TIMEOUT || '60' }} |
Contributor
Author
There was a problem hiding this comment.
10s timeout for deck commands is often not enough for konnect-dev APIs. Thus, increased them to 60 here.
harshadixit12
previously approved these changes
Mar 6, 2026
harshadixit12
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: Kong/go-database-reconciler#392
Konnect tests often require re-runs due to data races' based failures.
These races occur more often if we add more tests for konnect.
These data races are unpredictable due to the nature of golang's internal modules.
The change in GDR removes the main cause of the data race.
This PR aims to make development velocity faster by avoiding such data races in
Konnect or Kong gateway.
Added some corrections for konnect tests due to schema changes.