Skip to content

feat: get gRPC descriptor from dp set#216

Merged
LinuxSuRen merged 13 commits into
LinuxSuRen:masterfrom
Ink-33:grpc_decs
Sep 26, 2023
Merged

feat: get gRPC descriptor from dp set#216
LinuxSuRen merged 13 commits into
LinuxSuRen:masterfrom
Ink-33:grpc_decs

Conversation

@Ink-33

@Ink-33 Ink-33 commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

Now we can use descriptor set as descriptor source to invoke gRPC method.

About dp set: https://protobuf.dev/programming-guides/techniques/#self-description

Signed-off-by: Ink33 <Ink33@smlk.org>
Signed-off-by: Ink33 <Ink33@smlk.org>
@LinuxSuRen LinuxSuRen added enhancement New feature or request glcc Special for https://www.gitlink.org.cn/glcc backend grpc labels Sep 15, 2023

@LinuxSuRen LinuxSuRen left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see you already implemented the protoSet feature. I left some comments. And the relevant document is highly recommended. Users might want to know the following informations from it:

  • The description about the gRPC feature
  • How to use it
  • The explanation about the important fields

Comment thread pkg/runner/grpc.go
return dp, nil
}

func getByProtoSet(ctx context.Context, r *gRPCTestCaseRunner, fullName protoreflect.FullName) (protoreflect.Descriptor, error) {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding some unit tests for this function.

Comment thread .github/testing/grpc_decs.yaml
Comment thread .github/testing/grpc_decs.yaml
@Ink-33

Ink-33 commented Sep 15, 2023

Copy link
Copy Markdown
Contributor Author

Glad to see you already implemented the protoSet feature. I left some comments. And the relevant document is highly recommended. Users might want to know the following informations from it:

  • The description about the gRPC feature
  • How to use it
  • The explanation about the important fields

Since grpc is generally available, I will write a document to describe how to use it.

@LinuxSuRen

Copy link
Copy Markdown
Owner

Since grpc is generally available, I will write a document to describe how to use it.

The gRPC official document is good enough for the gRPC itself. You can just give it a reference. You could only provide what you did in this project.

@Ink-33

Ink-33 commented Sep 15, 2023

Copy link
Copy Markdown
Contributor Author

The gRPC official document is good enough for the gRPC itself. You can just give it a reference. You could only provide what you did in this project.

I means the document will be about how to create and run gRPC testcase, like a manual.

@LinuxSuRen

Copy link
Copy Markdown
Owner

I means the document will be about how to create and run gRPC testcase, like a manual.

Sure.

Signed-off-by: Ink33 <Ink33@smlk.org>
Signed-off-by: Ink33 <Ink33@smlk.org>
Signed-off-by: Ink33 <Ink33@smlk.org>
@LinuxSuRen

Copy link
Copy Markdown
Owner

A friendly reminder, the unit test is required, and the deadline of this program is very close. Please feel free to complete it if you have time.

@Ink-33

Ink-33 commented Sep 22, 2023

Copy link
Copy Markdown
Contributor Author

A friendly reminder, the unit test is required, and the deadline of this program is very close. Please feel free to complete it if you have time.

Thanks. The unit tests are almost complete and only need a little time. I'll push the commits later today and verify the effect.

Ink-33 and others added 6 commits September 25, 2023 00:38
Signed-off-by: Ink33 <Ink33@smlk.org>
Signed-off-by: Ink33 <Ink33@smlk.org>
Signed-off-by: Ink33 <Ink33@smlk.org>
Signed-off-by: Ink33 <Ink33@smlk.org>
Signed-off-by: Ink33 <Ink33@smlk.org>

@LinuxSuRen LinuxSuRen left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Do you still want to make any changes on this PR?

@Ink-33

Ink-33 commented Sep 25, 2023

Copy link
Copy Markdown
Contributor Author

This is great. Do you still want to make any changes on this PR?

Yes, I will complete docs about secure today.

doc: add docs about secure

Signed-off-by: Ink33 <Ink33@smlk.org>
@Ink-33

Ink-33 commented Sep 25, 2023

Copy link
Copy Markdown
Contributor Author

A little change to struct secure, please review it. Meanwhile, I think the works for this feature is completed.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@LinuxSuRen LinuxSuRen left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LinuxSuRen LinuxSuRen merged commit 7e5f93f into LinuxSuRen:master Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend enhancement New feature or request glcc Special for https://www.gitlink.org.cn/glcc grpc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants