Skip to content
This repository was archived by the owner on May 25, 2020. It is now read-only.

Add edit and deletion of transactions#210

Merged
grgur merged 16 commits into
ModusCreateOrg:masterfrom
jlangevin:edit-transaction
Dec 5, 2018
Merged

Add edit and deletion of transactions#210
grgur merged 16 commits into
ModusCreateOrg:masterfrom
jlangevin:edit-transaction

Conversation

@jlangevin
Copy link
Copy Markdown
Contributor

Proposed Changes

  • Add mouseover effect to transaction line item
  • Add click handler to transaction line item which opens form
  • Add action/reducer for updating existing transaction
  • Add delete button and ties in existing delete action/reducer
  • Convert button style in EntryFormRow to class with mix-in to allow appropriate button colors
  • Fixes truncation of add transaction form on narrow screen/phones.
  • Add flew wrap to allow space for new buttons on narrower screens

Screenshot

Wide screen
image

Wraps properly now on narrow screen instead of cutting off desc, value and buttons:
image

Checklist

  • Feature developed
  • Created/updated unit tests
  • Comments in code
  • Documentation written

Comment thread app/modules/transactions.js Outdated
Comment thread app/modules/__tests__/transactions-test.js Outdated
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 4, 2018

Coverage Status

Coverage decreased (-3.2%) to 74.286% when pulling f65dc54 on jlangevin:edit-transaction into 95e67da on ModusCreateOrg:master.

Comment thread app/modules/__tests__/transactions-test.js
Comment thread app/modules/__tests__/transactions-test.js Outdated
Comment thread app/modules/__tests__/transactions-test.js
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit a4d4174 and detected 0 issues on this pull request.

View more on Code Climate.

@grgur
Copy link
Copy Markdown
Member

grgur commented Dec 5, 2018

This is fantastic, thank you so much @jlangevin 🙌

@grgur grgur merged commit 407b7c6 into ModusCreateOrg:master Dec 5, 2018
@jlangevin
Copy link
Copy Markdown
Contributor Author

@grgur You're very welcome! Thanks!

@jlangevin jlangevin deleted the edit-transaction branch December 5, 2018 20:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants