Skip to content
This repository was archived by the owner on May 25, 2020. It is now read-only.

Add tests for EntryFormRow#211

Merged
grgur merged 5 commits into
ModusCreateOrg:masterfrom
jlangevin:EntryFormRow-tests
Dec 7, 2018
Merged

Add tests for EntryFormRow#211
grgur merged 5 commits into
ModusCreateOrg:masterfrom
jlangevin:EntryFormRow-tests

Conversation

@jlangevin
Copy link
Copy Markdown
Contributor

@jlangevin jlangevin commented Dec 6, 2018

Proposed Changes

  • Adds tests for new and previously-existing buttons
  • Update enzyme-adapter-react-16 to fix error throw by mount()

Screenshot

image

image

Checklist

  • Feature developed
  • Created/updated unit tests
  • Comments in code
  • Documentation written

Comment thread app/containers/EntryFormRow/__tests__/index.js
});
});

describe('Delete button', () => {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

Comment thread app/containers/EntryFormRow/__tests__/index.js Outdated
Comment thread app/containers/EntryFormRow/__tests__/index.js
Comment thread app/containers/EntryFormRow/__tests__/index.js Outdated
Comment thread app/containers/EntryFormRow/__tests__/index.js
Comment thread app/containers/EntryFormRow/__tests__/index.js
Comment thread app/containers/EntryFormRow/__tests__/index.js Outdated
Comment thread app/containers/EntryFormRow/__tests__/index.js Outdated
Comment thread app/containers/EntryFormRow/__tests__/index.js Outdated
@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit b3f4bd0 and detected 0 issues on this pull request.

View more on Code Climate.

@grgur
Copy link
Copy Markdown
Member

grgur commented Dec 7, 2018

You crushed it! Thanks @jlangevin

@grgur grgur merged commit 9a91272 into ModusCreateOrg:master Dec 7, 2018
@grgur
Copy link
Copy Markdown
Member

grgur commented Dec 7, 2018

@jlangevin just wondering - how did you find this and how are you using the app? I'm just curious to learn about use cases.

@jlangevin
Copy link
Copy Markdown
Contributor Author

@grgur To be honest, I'm not using at the moment. However, I've been kicking around an idea for a budget-related app and might use it as a starter. If I do, I'd want editing and deleting and figured others would as well. So I used this as an opportunity to get familiar with the code, and this way others can benefit too. As for how I found this, I'm friends with Tim Eagan and clicked through to Modus Create's repos on a whim the other day. Thanks for putting this stuff out there. I always enjoy learning how other folks approach things. I also hadn't used Code Climate before, which dare I say, I've really grown to like.

@jlangevin
Copy link
Copy Markdown
Contributor Author

@grgur Also, thanks for the kind words on my work!

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 8, 2018

Coverage Status

Coverage increased (+8.6%) to 82.709% when pulling b3f4bd0 on jlangevin:EntryFormRow-tests into 407b7c6 on ModusCreateOrg:master.

@jlangevin jlangevin deleted the EntryFormRow-tests branch December 11, 2018 16:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants