[10.0][MIG] geoengine_partner#160
Conversation
yvaucher
left a comment
yvaucher
left a comment
There was a problem hiding this comment.
I started to review then figured our a lot of change were made in base_geoengine.
I guess you wanted to fix PEP8 issues. May I suggest you to do this in another PR?
|
|
||
| # technical field to display or not wmts options | ||
| is_wmts = fields.Boolean(compute='_compute_is_wmts') | ||
| is_wmts = fields.Boolean(compute='_get_is_wmts') |
There was a problem hiding this comment.
please keep _compute as it is an OCA convention for computed fields.
base_geoengine/geo_view/geo_raster_layer.py:38: [C8108(method-compute), GeoRasterLayer] Name of compute method should start with "compute"
base_geoengine/geo_view/geo_raster_layer.py:59: [C8108(method-compute), GeoRasterLayer] Name of compute method should start with "compute"
| use_to_edit = fields.Boolean('Use to edit') | ||
|
|
||
| @api.multi | ||
| @api.one |
There was a problem hiding this comment.
consider api.one as deprecated, there was some flip flop about it but the final result is that it is discouraged to use it.
|
Oops, you are right there are some unwanted changes here! I just tried to replace the |
|
@yvaucher I think it's better now! |
|
It seems that odoo-sphinx-autodoc is creating errors in the travis test instance... |
|
@yvaucher I guess you can review now. I just replaced openerp imports with odoo, otherwise it's only geoengine_partner changes. |
[FIX] Google map views markers located on the same coordinate
2 participants
Migrate geoengine partner module