Refactored language file.#7
Refactored language file.#7daviwil merged 31 commits intoPowerShell:masterfrom gravejester:Refactoring
Conversation
…se in double-quoted strings.
|
Hi @gravejester, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
@gravejester, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
Nice bot. :) |
|
Awesome! So many great improvements here. I was just spot checking the before and after examples you linked to and noticed this: Looks like the This is excellent work, man. Once you feel like you're done making changes for now you should submit a pull request to the VS Code repo to replace this file: I want you to get the credit for these contributions by getting your PR accepted there :) |
|
And when you submit your PR to VS Code, mention me in the PR message so that I can jump in and encourage them to accept the change. |
|
heh.. that is actually just a typo in the comment, it should say 'shouldn't' :D |
|
Ahhh! That makes more sense :) Great, merging this now, thanks again! |
|
Cool, thanks! :) |
For details see PowerShell/EditorSyntax#7

This is all my commits since forking the main repository. It includes the first commits where I tried to fix the bugs in the matching rules, but at some point I decided to do a complete refactoring of the whole file.
Notable changes:
{default}Use these links to check before/after:
Old vs New