Skip to content

fix xml typos#96

Merged
TylerLeonhardt merged 1 commit intoPowerShell:masterfrom
omniomi:fix-typos
May 14, 2018
Merged

fix xml typos#96
TylerLeonhardt merged 1 commit intoPowerShell:masterfrom
omniomi:fix-typos

Conversation

@omniomi
Copy link
Copy Markdown
Contributor

@omniomi omniomi commented May 14, 2018

Two token issues in the XML.

@TylerLeonhardt
Copy link
Copy Markdown
Member

Didn't you also fix this in the other PR?

Copy link
Copy Markdown
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@omniomi
Copy link
Copy Markdown
Contributor Author

omniomi commented May 14, 2018

@tylerl0706 yessir. I fixed it in the WIP.

@TylerLeonhardt
Copy link
Copy Markdown
Member

Do you wanna just close this in favor of the WIP then?

@omniomi
Copy link
Copy Markdown
Contributor Author

omniomi commented May 14, 2018

@tylerl0706 hard to say... WIP could be another day or two. This issue doesn't affect editors that build the tml to json but anything that tries to use the tml file directly will error without it.

@TylerLeonhardt
Copy link
Copy Markdown
Member

Gotcha. We can merge this in then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants