Skip to content

Less [String]() #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ikesyo merged 1 commit into from
Aug 28, 2021
Merged

Less [String]() #1090

ikesyo merged 1 commit into from
Aug 28, 2021

Conversation

@RomanPodymov
Copy link
Contributor

@RomanPodymov RomanPodymov commented Aug 3, 2021

Hello.
Thank you for Quick.
Refactored FunctionalTests_ItSpec with less [String]().

Checklist - While not every PR needs it, new features should consider this list:

  • Does this have tests?
  • Does this have documentation?
  • Does this break the public API (Requires major version bump)?
  • Is this a new feature (Requires minor version bump)?

ikesyo
ikesyo approved these changes Aug 28, 2021
View reviewed changes
Copy link
Member

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ikesyo ikesyo merged commit 519e91b into Quick:main Aug 28, 2021
@jessesquires jessesquires added this to the v5.0.0 milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikesyo ikesyo ikesyo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@RomanPodymov @ikesyo @jessesquires