Skip to content

fix set sqlite3 propertie#212

Merged
SRombauts merged 1 commit intoSRombauts:masterfrom
jiangzhuti:jiangzhuti-patch-1
Aug 26, 2019
Merged

fix set sqlite3 propertie#212
SRombauts merged 1 commit intoSRombauts:masterfrom
jiangzhuti:jiangzhuti-patch-1

Conversation

@jiangzhuti
Copy link
Copy Markdown
Contributor

No description provided.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 96.586% when pulling 7c2c62a on jiangzhuti:jiangzhuti-patch-1 into c1ab707 on SRombauts:master.

@SRombauts SRombauts self-assigned this Aug 25, 2019
@SRombauts
Copy link
Copy Markdown
Owner

Hi!

Thanks for this, but can you explain the logic? I think we might actually want both sqlite3 and SQLiteCpp as dynamic libraries, depending on the use cases?

@jiangzhuti
Copy link
Copy Markdown
Contributor Author

jiangzhuti commented Aug 26, 2019

Hi!

Thanks for this, but can you explain the logic? I think we might actually want both sqlite3 and SQLiteCpp as dynamic libraries, depending on the use cases?

https://github.com/SRombauts/SQLiteCpp/blob/master/CMakeLists.txt#L192 VS https://github.com/SRombauts/SQLiteCpp/blob/master/sqlite3/CMakeLists.txt#L15

@SRombauts SRombauts merged commit 629497e into SRombauts:master Aug 26, 2019
@SRombauts
Copy link
Copy Markdown
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants