Allow building of sqlite JSON1 extension when building internal sqlite library#288
Merged
SRombauts merged 1 commit intoSRombauts:masterfrom Aug 3, 2020
Merged
Conversation
Owner
|
Hi @Zxey I wasn't aware of this extension, do you know since when it exists? Anyway, I think it's a great feature 👍 The only small change I would propose is to actually set SQLITE_ENABLE_JSON1 publicly so the client code would be able to test for this feature. |
Contributor
Author
|
It seems that it has been available since sqlite version 3.9.0 as seen in changelog https://sqlite.org/search?s=c&q=JSON1 |
This was referenced May 29, 2023
Owner
|
See PR #428 for the new branch I just pushed: For us with SQLiteCpp it would be since Version 3.2.0 - 2022 September 18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added cmake option to enable json1 extension when building internal sqlite library.
I added the option under the SQLITECPP_INTERNAL_SQLITE
ifstatement so it is clear that this option is only valid when building the internal sqlite library.