Add Database constructor for filesystem::path #296#314
Merged
SRombauts merged 5 commits intoSRombauts:masterfrom Jan 6, 2021
Merged
Add Database constructor for filesystem::path #296#314SRombauts merged 5 commits intoSRombauts:masterfrom
SRombauts merged 5 commits intoSRombauts:masterfrom
Conversation
…nsitioned from std::experimental until MSVC 15.7
Owner
|
Thanks a lot for providing this! |
Contributor
Author
|
Of course! |
Owner
Contributor
|
Possible fix is to convert std::wstring to utf-8 based string: |
|
As sum01 remarked, the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an additional constructor in
Database.hthat accepts astd::filesystem::pathobject. Also updated thectorExecCreateDropExistunit test inDatabase_test.hwhich will test the new constructor if the detected compiler supports c++17.