add disable option for sqlite3_expanded_sql#399
Merged
SRombauts merged 2 commits intoSRombauts:masterfrom Feb 2, 2023
UnixY2K:optional-sqlite3_expanded_sql
Merged
add disable option for sqlite3_expanded_sql#399SRombauts merged 2 commits intoSRombauts:masterfrom UnixY2K:optional-sqlite3_expanded_sql
SRombauts merged 2 commits intoSRombauts:masterfrom
UnixY2K:optional-sqlite3_expanded_sql
Conversation
make sqlite3_expanded_sql use optional and give a warning at compile time along with a exception at runtime when used in an application
Contributor
Author
|
I think that we could also add an special exception like Edit:
|
Owner
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an option to disable
sqlite3_expanded_sqlthat disables the internal use of it inside the methodStatement::getExpandedSQLso it gives a warning when building SQLiteCpp, at runtime it will give an exception insteadthis should fix #213
changes
SQLITECPP_DISABLE_EXPANDED_SQLoption along with the defineSQLITECPP_DISABLE_EXPANDED_SQLSQLITECPP_DISABLE_EXPANDED_SQLthat definesSQLITECPP_DISABLE_EXPANDED_SQLSQLITECPP_DISABLE_EXPANDED_SQLis not defined when running the version of sqlite < 3.14.0Statement::getExpandedSQLif compiled witouth support forsqlite3_expanded_sql