Implement Iterator.prototype.find method#1451
Merged
ksh8281 merged 1 commit intoSamsung:masterfrom Jul 2, 2025
Merged
Conversation
a16933e to
7003eba
Compare
Contributor
|
Please rebase this patch again 🥲 |
1d11d53 to
4495803
Compare
Signed-off-by: 2jaeheon <jaeheon0826@jbnu.ac.kr>
Contributor
Author
|
I checked the history with git reflog and rolled back to a point before multiple clang-related changes were introduced. After that, I rebased and resolved the issue accordingly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the implementation of the
Iterator.prototype.findmethod, aligning with the TC39 Iterator Helpers proposal. Key changes include the addition of thefindmethod to the iterator prototype, its integration into the global object, and updates to the test suite to reflect the new functionality.Implementation of
Iterator.prototype.find:Addition of
builtinIteratorFindmethod: Implemented the logic forIterator.prototype.find, including validation of thethisvalue and thepredicateargument, iteration over the iterator, and handling of abrupt completions. (src/builtins/BuiltinIterator.cpp, src/builtins/BuiltinIterator.cppR191-R245)Integration into the iterator prototype: Registered the
findmethod on them_iteratorPrototypeobject with proper property attributes (writable and configurable). (src/builtins/BuiltinIterator.cpp, src/builtins/BuiltinIterator.cppR320-R322)Test suite updates:
Iterator.prototype.findtests from exclusion list: Marked severalIterator.prototype.findtests as no longer excluded, indicating the feature is now implemented and ready for testing. (tools/test/test262/excludelist.orig.xml, tools/test/test262/excludelist.orig.xmlL505-L529)