fix: prevent crash when enabling system tray on KDE Plasma 6 / Wayland#381
Merged
Conversation
On Linux systems without libayatana-appindicator3 or libappindicator3 installed (common on KDE Plasma 6 / Wayland), libappindicator-sys panics inside an extern "C" function when TrayIconBuilder::build() is called. Because the panic cannot unwind, the process aborts. Since tray_icon_enabled is persisted to SQLite before the crash, every subsequent launch also aborts before the window appears. Fix: probe for the shared library via dlopen before calling TrayIconBuilder::build(). If none of the four candidate .so names are loadable, create_tray returns early with a warning log instead of aborting the process. To prevent the setting from being enabled on unsupported systems, the System Tray section in Settings > System is now hidden on Linux when the probe fails. A new tray_supported IPC command exposes the probe result to the frontend, called once on mount in SystemSection. The library can be installed on Arch / Manjaro with: `sudo pacman -S libayatana-appindicator`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux systems without libayatana-appindicator3 or libappindicator3 installed (common on KDE Plasma 6 / Wayland), libappindicator-sys panics inside an extern "C" function when TrayIconBuilder::build() is called. Because the panic cannot unwind, the process aborts. Since tray_icon_enabled is persisted to SQLite before the crash, every subsequent launch also aborts before the window appears.
Fix: probe for the shared library via dlopen before calling TrayIconBuilder::build(). If none of the four candidate .so names are loadable, create_tray returns early with a warning log instead of aborting the process.
To prevent the setting from being enabled on unsupported systems, the System Tray section in Settings > System is now hidden on Linux when the probe fails. A new tray_supported IPC command exposes the probe result to the frontend, called once on mount in SystemSection.
The library can be installed on Arch / Manjaro with:
sudo pacman -S libayatana-appindicatorResolves #380