fix: restore tray-hidden windows#404
Merged
Merged
Conversation
Owner
|
Looks good, and thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes two tray-related window restore issues:
Problem
When system tray support and close-to-tray are enabled, but minimize-to-tray is disabled, the main window can enter states that are not handled correctly by the current tray restore logic.
Case 1: minimized window does not restore from tray
Configuration:
Steps:
Expected:
The main window should be restored and focused.
Actual:
The window may remain hidden/minimized because the tray click handler only checks
is_visible(). On some platforms a minimized window can still be reported as visible, so the handler chooseshide()instead of restore.Case 2: close button remains visually selected after tray restore
Configuration:
Steps:
Expected:
The restored window should not keep the close button in a hover/focus-like visual state, and pressing Enter should not trigger the previously focused close button.
Actual:
The close button can remain visually highlighted/red after restore, and the focused control state is not cleared.
Changes
TrayWindowActiondecision helper that treats minimized windows as restore targets.show(),unminimize(), andset_focus().Showaction.:focus-visible.Testing
Tested manually on Windows:
Commands run:
cargo test --manifest-path src-tauri/Cargo.toml tray_click npm run check