Skip to content
This repository was archived by the owner on Oct 17, 2021. It is now read-only.

fixed ubuntu Illegal Instruction issue#2

Merged
mattt merged 2 commits into
SwiftDocOrg:masterfrom
JaapWijnen:ubuntu-illegal-instruction-fix
Jul 15, 2020
Merged

fixed ubuntu Illegal Instruction issue#2
mattt merged 2 commits into
SwiftDocOrg:masterfrom
JaapWijnen:ubuntu-illegal-instruction-fix

Conversation

@JaapWijnen

Copy link
Copy Markdown
Contributor

This solves SwiftDocOrg/swift-doc#133
swift-doc itself should be updated to a new version of GraphViz in order for this to work. (plus receive a minor change in a second PR to swift-doc as soon as GraphViz's version is updated)

@mattt

mattt commented Jul 15, 2020

Copy link
Copy Markdown
Contributor

I can't thank you enough for digging into this, @JaapWijnen. I'm sorry that this ended up causing problems downstream that were hard to pin down. Merging this now and cutting a new release ahead of incorporating your corresponding fix in swift-doc.

@mattt mattt merged commit b4bcd4d into SwiftDocOrg:master Jul 15, 2020
@mattt

mattt commented Jul 15, 2020

Copy link
Copy Markdown
Contributor

This is fixed in 0.1.2. I'll document this in a proper Changelog soon. (#3)

@JaapWijnen

JaapWijnen commented Jul 15, 2020

Copy link
Copy Markdown
Contributor Author

Awesome thank you @mattt ! :) I've submitted a PR for fixing swift-doc as well! SwiftDocOrg/swift-doc#140

@JaapWijnen JaapWijnen deleted the ubuntu-illegal-instruction-fix branch July 15, 2020 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants