Add end-to-end tests for command-line interface#199
Conversation
MaxDesiatov
added
the
continuous integration
|
Thanks for getting started on this, @MaxDesiatov. I agree with your instinct to start with a shell script for this. Given that the primary offering of |
|
Sure, let's do that. I'll update the PR accordingly 👍 |
|
@mattt ready for review 🙂 |
|
@MaxDesiatov Nice! Taking a look now. |
mattt
left a comment
mattt
left a comment
There was a problem hiding this comment.
A few suggested changes for your consideration. Would it be alright if I iterate on this some more this morning, and add some more test cases (e.g. to handle CSS and HTML formats)?
Co-authored-by: Mattt <mattt@me.com>
|
Sure, please do! |
Create helper methods on Process and Bundle
Co-authored-by: Max Desiatov <max@desiatov.com>
|
@MaxDesiatov Any last changes before this gets merged? |
|
LGTM, thank you for finishing this up! |
|
Can I merge this now? Do you prefer merge commits or linear history by the way? |
|
@MaxDesiatov I like to squash and merge PRs. Feel free to do the honors of hitting that green button 😄 (and thanks again for your help with this!) |
mattt
changed the title
all.css contains a valid CSS selector2 participants
Verifies that generated
all.csscontains the:rootstring on CI. It doesn't do any actual CSS parsing to verify its full validity, only does a simplegrepcheck, but I hope this will be enough to prevent issues like #198 in the future.