Try to setup GUI, iff noGui is False #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Will need to test this before it is merged, but thanks for your contribution. It is definitely desirable to allow those without PySide to use the command line interface version of Syncplay. |
Contributor
|
Only quickly tried to test, but I couldn't get it to work. It seems that when you run it and then have GuiConfig load by default and then run Syncplay from GuiConfig it adds an additional :8996 to the end of the host/ports which causes Syncplay to fail to connect. Not sure, but I think it is related to the fact that the new code causes _validateArguments to be called twice BEFORE the GuiConfig dialogue is closed and not at all afterwards. Have you tested it with forceGuiPrompt being true in your config file and PySide installed? |
This prevents the error message from being displayed when GUI is disabled on systems without PySide Additionally, remove some redundant conditionals
Hummer12007
force-pushed
the
automagic
branch
from
d9b40e6 to
002773c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the import error message from being displayed when GUI is
disabled on systems without PySide
Additionally, remove some redundant conditionals