Skip to content

add files to playlist from chat #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csandras05 wants to merge 1 commit into from
Closed

add files to playlist from chat #319

csandras05 wants to merge 1 commit into from

Conversation

@csandras05
Copy link
Contributor

@csandras05 csandras05 commented Jun 3, 2020

Had some issues with git, reopening PR #316 with the requested changes.

@daniel-123
Copy link
Contributor

daniel-123 commented Jun 3, 2020

Trying to call the "q" command to add file to playlist while in CLI mode (--no-gui) results in TypeError: addFileToPlaylist() takes 1 positional argument but 2 were given in client.py on line 1550.

@Et0h
Copy link
Contributor

Et0h commented Jun 3, 2020 •
edited
Loading

@daniel-123 I don't think that is due to this PR, I think it is because the def addFileToPlaylist(self): stub in consoleUI.py needs to accept more parameters (e.g. it should be def addFileToPlaylist(self, filePath, index=-1): like in gui.py). We could also make it give an appropriate error message saying that playlists are not currently supported in console made (rather than just doing a pass).

@daniel-123
Copy link
Contributor

daniel-123 commented Jun 5, 2020

I've tried out the CLI mode for a bit. Given it's current state with effective lack of playlist support I think I'd be happy with a solution that simply doesn't crash the client.

Fleshing out CLI mode to include media directories support and eventually proper playlist support is a possible separate goal, but given that GUI is by far the primary mode of use I would see it as low priority and out of scope for this PR.

@odrling odrling mentioned this pull request Jun 21, 2020
Merged
@Et0h
Copy link
Contributor

Et0h commented Aug 14, 2020

#327 uses #319 as its base. At present I'm minded to go with a tweaked version of #327 instead of #319 because as far as I'm aware #327 contains the benefits of #319 and more.

Et0h pushed a commit that referenced this pull request Sep 13, 2020
@odrling @csandras05
Console improvements (#327), including work from #316 and #319
b09fb90 
* add videos to playlist from chat

* add urls to playlist

* add files in media directory to playlist

* add commands to show the playlist and select an index

* add command to delete files from the playlist

* show selected index in playlist

* fix adding files with queue command in GUI mode

* start indexing the playlist at 1

or at least that's what it would look like to the user

* start all commands related to playlist with `q`

Co-authored-by: kiscs <csandras05@gmail.com>
@Et0h
Copy link
Contributor

Et0h commented Sep 17, 2020

Relevant elements incorporated into #327 which has now been merged.

@Et0h Et0h closed this Sep 17, 2020
albertosottile pushed a commit to albertosottile/syncplay that referenced this pull request Sep 30, 2020
@odrling @csandras05 @albertosottile
Console improvements (Syncplay#327), including work from Syncplay#316 …
62af7e8 
…and Syncplay#319

* add videos to playlist from chat

* add urls to playlist

* add files in media directory to playlist

* add commands to show the playlist and select an index

* add command to delete files from the playlist

* show selected index in playlist

* fix adding files with queue command in GUI mode

* start indexing the playlist at 1

or at least that's what it would look like to the user

* start all commands related to playlist with `q`

Co-authored-by: kiscs <csandras05@gmail.com>
albertosottile pushed a commit to albertosottile/syncplay that referenced this pull request Sep 30, 2020
@odrling @csandras05 @albertosottile
Console improvements (Syncplay#327), including work from Syncplay#316 …
4bef921 
…and Syncplay#319

* add videos to playlist from chat

* add urls to playlist

* add files in media directory to playlist

* add commands to show the playlist and select an index

* add command to delete files from the playlist

* show selected index in playlist

* fix adding files with queue command in GUI mode

* start indexing the playlist at 1

or at least that's what it would look like to the user

* start all commands related to playlist with `q`

Co-authored-by: kiscs <csandras05@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@csandras05 @daniel-123 @Et0h