Skip to content

Conversation

@daniel-123
Copy link
Contributor

Addresses the #375 and #335

@daniel-123 daniel-123 marked this pull request as ready for review January 24, 2021 12:30
@daniel-123
Copy link
Contributor Author

The workflow outputs both deb packages inside single zip. Which might be somewhat inconvenient, but doesn't seem like an issue since no matter what it has to be unpacked anyway. This might change once it's possible to create non-zipped artifacts with Actions.

The server deb package currently includes some excess files which are used only by the client, all the icons etc. There is no trivial way to trim it in maintenance-free way so I left it out from this PR. Later on it can be adjusted by modifying the GNUMakefile.

@albertosottile
Copy link
Member

LGTM, I am just not sure if the server package will support also TLS, because I do not know if the python3-twisted package includes the dependencies of the [tls] extra.

@daniel-123
Copy link
Contributor Author

python3-twisted itself has a hard dependency on python3-openssl. I'm pretty sure there isn't any separate package with just tls parts of twisted on Debian and presumably any of its derivatives.

On both environments I tested this in, the requirements specified were sufficient for TLS support.

@daniel-123 daniel-123 merged commit f57df2c into master Jan 25, 2021
@daniel-123 daniel-123 deleted the server-deb branch January 27, 2021 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants