Skip to content

Conversation

@Et0h
Copy link
Contributor

@Et0h Et0h commented Feb 21, 2023

This should fix errors such as:

File "syncplay\players\mpv.pyc", line 743, in actuallySendLine
File "syncplay\client.pyc", line 1626, in showDebugMessage
builtins.UnicodeEncodeError: 'charmap' codec can't encode character '\u3009' in position 684: character maps to

When using Syncplay with mpv and--debug mode on Windows.

@Et0h
Copy link
Contributor Author

Et0h commented Feb 21, 2023

This seems to fix this issue which I experienced when running Syncplay with mpv when --debug was enabled. If nobody objects I'll merge it soon.

Context: The \u3009 symbol is a Unicode right-angle bracket, and it is the MPV_INPUT_PROMPT_START_CHARACTER specified in constants.py which is passed onto mpv to define the character which appears when you press enter to show you can write your message within mpv.

@Et0h Et0h merged commit a6b8b6d into master Feb 28, 2023
@Et0h Et0h deleted the unicode_logging branch February 28, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants