Environment variable flag to preserve unmodified, raw trace headers from SEG-Y as variable. #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #659 +/- ##
==========================================
+ Coverage 85.30% 87.01% +1.71%
==========================================
Files 46 82 +36
Lines 2219 4576 +2357
Branches 306 303 -3
==========================================
+ Hits 1893 3982 +2089
- Misses 281 515 +234
- Partials 45 79 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tasansal
force-pushed
the
disaster_recovery_multiVersionSupport
branch
2 times, most recently
from
908c97b to
9ae7ab6
Compare
- Avoids duplicate read regression issue - Implements isolated and testable logic
tasansal
force-pushed
the
disaster_recovery_multiVersionSupport
branch
from
9ae7ab6 to
7a30489
Compare
tasansal
suggested changes
Sep 19, 2025
tasansal
suggested changes
Sep 19, 2025
* Attempt to use view * Add hex-dump and MDIO output reproducer * Fixes * Cleanup * Provide clean disaster recovery interface * Begin work on tests * Fix flattening issue * Push for debugging * Numpy updates * Testing * Working end-to-end examples * Cleanup * Bandaid fix * linting pass 1 * Fix logic issue * Use wrapper class * Precommit * Remove external debugging code * Remove debug code * Remove errant numpy additon to pyproject toml * Fix uv lock to mainline * Pre-commit * Remove raw field additions. Depends on segy >= 0.5.1 * Removed raw byte inserts (#10) * Update Xarray api access (TGSAI#688) * Reimplement disaster recovery logic * Ensure getting true raw bytes for DR array * Linting * Add v2 issue check * Fix pre-commit * Profiled disaster recovery array (#8) - Avoids duplicate read regression issue - Implements isolated and testable logic * Fix unclosed parenthesis * Linting * Test DR compatibility with all tested schemas * Fix missing test fixture error * Suppress unused linting error * Attempt to use view * Add hex-dump and MDIO output reproducer * Fixes * Cleanup * Provide clean disaster recovery interface * Begin work on tests * Fix flattening issue * Push for debugging * Numpy updates * Testing * Working end-to-end examples * Cleanup * Bandaid fix * linting pass 1 * Fix logic issue * Use wrapper class * Precommit * Remove external debugging code * Remove debug code * Remove errant numpy additon to pyproject toml * Fix uv lock to mainline * Pre-commit * Removed raw byte inserts Removed the insertions of raw bytes into the raw bytes Variable. This issue will be addressed in tgsai/segy release >0.5.1 * Use new segy API calls * Updates to get working * Use released version * Linting
# Conflicts: # pyproject.toml # uv.lock
tasansal
approved these changes
Sep 30, 2025
Contributor
tasansal
left a comment
tasansal
left a comment
There was a problem hiding this comment.
LGTM but hopefully we can remove this soon!
tasansal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #634
Pending work
Notes:
Requires environment variable
MDIO__DO_RAW_HEADERS1Will generate a logger warning regarding experimental status if the feature is enabled.