(Re)implement dynamic chunking for live mask and non-dimension coordinates #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
==========================================
+ Coverage 85.30% 87.15% +1.84%
==========================================
Files 46 82 +36
Lines 2219 4623 +2404
Branches 306 307 +1
==========================================
+ Hits 1893 4029 +2136
- Misses 281 515 +234
- Partials 45 79 +34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tasansal
force-pushed
the
587_on-the-fly_chunking
branch
from
1eec54b to
547cdb9
Compare
tasansal
changed the title
tasansal
approved these changes
Oct 1, 2025
Contributor
tasansal
left a comment
tasansal
left a comment
There was a problem hiding this comment.
LGTM, we can tweak this later if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #620
Same logic is implemented with only changes being how the Pydantic models are used.