Skip to content

Conversation

@BrianMichell
Copy link
Collaborator

Resolves #661

@codecov
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.69%. Comparing base (c3ba558) to head (c4b061e).
⚠️ Report is 160 commits behind head on main.

Files with missing lines Patch % Lines
src/mdio/segy/_workers.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   85.30%   86.69%   +1.38%     
==========================================
  Files          46       80      +34     
  Lines        2219     4321    +2102     
  Branches      306      284      -22     
==========================================
+ Hits         1893     3746    +1853     
- Misses        281      500     +219     
- Partials       45       75      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tasansal
Copy link
Contributor

LGTM, but what is puzzling to me is, how did the patch coverage go to 50% ?

@tasansal tasansal added the enhancement New feature or request label Sep 15, 2025
@tasansal tasansal changed the title Fix for hardcoded sentinel value Fix for hardcoded fill value for local grid map in trace worker Sep 15, 2025
@tasansal tasansal merged commit 1417d97 into TGSAI:main Sep 15, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indexing sentinel logic issue

3 participants