-
Notifications
You must be signed in to change notification settings - Fork 16
Internal environment variable handling and documentation #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #730 +/- ##
==========================================
+ Coverage 85.30% 87.23% +1.92%
==========================================
Files 46 88 +42
Lines 2219 4826 +2607
Branches 306 318 +12
==========================================
+ Hits 1893 4210 +2317
- Misses 281 544 +263
- Partials 45 72 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tasansal
suggested changes
Oct 24, 2025
860339a to
adf9193
Compare
tasansal
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the internal MDIO API leverages multiple environment variables for different runtime configuration options. The getters for all of these configurations are all scattered, leverage raw
os.environcalls, have differing levels of validation, and possibly rely on opaque defaults.This PR seeks to create a unified repository of runtime configuration options for enhanced clarity and documentation.
New documentation page