Skip to content

Conversation

@BrianMichell
Copy link
Collaborator

@BrianMichell BrianMichell commented Oct 21, 2025

Currently the internal MDIO API leverages multiple environment variables for different runtime configuration options. The getters for all of these configurations are all scattered, leverage raw os.environ calls, have differing levels of validation, and possibly rely on opaque defaults.

This PR seeks to create a unified repository of runtime configuration options for enhanced clarity and documentation.

New documentation page

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 94.64286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.23%. Comparing base (c3ba558) to head (be2eae5).
⚠️ Report is 206 commits behind head on main.

Files with missing lines Patch % Lines
src/mdio/segy/_workers.py 33.33% 2 Missing ⚠️
src/mdio/converters/segy.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
+ Coverage   85.30%   87.23%   +1.92%     
==========================================
  Files          46       88      +42     
  Lines        2219     4826    +2607     
  Branches      306      318      +12     
==========================================
+ Hits         1893     4210    +2317     
- Misses        281      544     +263     
- Partials       45       72      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BrianMichell BrianMichell marked this pull request as ready for review October 22, 2025 13:54
@BrianMichell BrianMichell added documentation Improvements or additions to documentation refactoring Refactoring labels Oct 22, 2025
@BrianMichell BrianMichell requested a review from tasansal October 22, 2025 15:13
@tasansal tasansal force-pushed the environment_enhancements branch from 860339a to adf9193 Compare October 25, 2025 21:00
@tasansal tasansal self-requested a review October 28, 2025 23:17
@tasansal tasansal merged commit 62fe311 into TGSAI:main Oct 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation refactoring Refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants